fix: resolve directory names for groups in favorites add - #23
Merged
Conversation
favorites add was calling ListGroupsEligibility directly, bypassing the directory name enrichment that fetchGroupsEligibility provides. Groups displayed as "Group: X (azure)" instead of "Directory: Y / Group: X (azure)". - Replace raw ListGroupsEligibility calls with fetchGroupsEligibility in both the unified interactive path and the --type groups path - Add eligLister param to addGroupFavorite for buildDirectoryNameMap - Add nil guard to buildDirectoryNameMap for graceful degradation - Add tests verifying directory name enrichment and nil eligLister fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grant favorites addwas callingListGroupsEligibilitydirectly in both the unified interactive path and the--type groupspath, bypassing thefetchGroupsEligibilityhelper that enriches groups with directory names viabuildDirectoryNameMapGroup: X (azure)instead ofDirectory: Y / Group: X (azure), inconsistent with the root commandfetchGroupsEligibility, added nil guard tobuildDirectoryNameMapfor graceful degradationTest plan
make test— all existing and new tests passmake build && ./grant favorites add— groups showDirectory: X / Group: Y (azure)format./grant— same format, confirming parity with root command